Fix GitHub issue 3881 #3898
Open
Fix GitHub issue 3881 #3898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3881
This pull request introduces enhancements to the
pluginModuleFederationfunctionality in thersbuild-pluginpackage, focusing on improving flexibility and adding test coverage. The key changes include making thersbuildOptionsparameter optional and adding comprehensive unit tests for thepluginModuleFederationfunction.Enhancements to
pluginModuleFederation:rsbuildOptionsparameter optional in thepluginModuleFederationfunction, improving its usability by allowing it to be called without explicitly passing configuration options. (packages/rsbuild-plugin/src/cli/index.ts, packages/rsbuild-plugin/src/cli/index.tsL101-R101)Added unit tests:
index.test.tsto validate the behavior of thepluginModuleFederationfunction under different scenarios, including cases with and without thersbuildOptionsparameter. This ensures the function behaves as expected in all supported configurations. (packages/rsbuild-plugin/src/cli/index.test.ts, packages/rsbuild-plugin/src/cli/index.test.tsR1-R29)